Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim long text in form controls and username block #887

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Oct 20, 2023

Description:

This pull request contains minor fixes that occur when the user has a very long name and there are long choices in form elements.
In these cases, we have the text or element coming out of the sizes of the containers reserved for their display.

Screenshots before:

text overloading with an extremely long username incorrect left padding with a long username on mobile text overloading with a long option in form select
image image image

Screenshots after:

with a long username with trimming with a short username
image image
with a long username without trimming with a long username with trimming
image image
with a long option in form select with a short option in form select
image image

Related Pull Requests:

PR to the master branch: #888
PR to the open-release/quince.master branch: #899

@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 20, 2023
@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim backport PR backports a change from main to a named release. labels Oct 20, 2023
@e0d
Copy link

e0d commented Oct 24, 2023

@ihor-romaniuk looks like there a few failures.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2023
@ihor-romaniuk
Copy link
Contributor Author

@e0d Sorry for that. Snapshots were updated.

@justinhynes justinhynes merged commit 1a4174d into openedx:open-release/palm.master Nov 8, 2023
5 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the fix/text-overflow-in-form-controls-and-username branch November 13, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants