Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] build: demonstrate using localhost.stage.edx.org #763

Closed
wants to merge 2 commits into from

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented May 31, 2023

PoC Demo of MFE Development w/o Devstack 🤘

Purpose

To increase the FE development iteration speed. To reduce the cognitive load required to make changes so developers can focus on delivering customer value.

MFE development relies by default on devstack-based services. To run any individual devstack service a developer has to run almost every devstack service - this requires a lot of effort and cognitive load to configure and maintain. Frontend engineers would benefit from an option to run no/fewer devstack services.

A positive side-effect is the data in stage will become better maintained through the normal course of developer-effort.

HowTo

Stage Resources

Additional Supporting Context

We've made some additional config tweaks on stage to support this. Some are temporary until we figure out a cleaner path.

  • CORS origin allowlist for localhost.stage.edx.org
    • for testing, it's CORS_ORIGIN_ALLOW_ALL: true for now on courses.stage.edx.org until a better strategy is figured out.
  • CSRF_TRUSTED_ORIGINS needs .edx.org:{PORT}

Future Improvements & Questioins

  • allow python IDAs to run w/ stage dependencies (ie run less devstack)
    • devstack decoding of stage JWT tokens?

@adamstankiewicz adamstankiewicz marked this pull request as draft May 31, 2023 18:25
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (45be830) 72.22% compared to head (9615bca) 72.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files          75       75           
  Lines        1073     1073           
  Branches      185      185           
=======================================
  Hits          775      775           
  Misses        288      288           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

chore: remove optimizely project id
module.exports = createConfig('webpack-dev', {
devServer: {
allowedHosts: 'all',
https: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: on later versions of @edx/frontend-build and Webpack, the https setting should be replaced with server: 'https'.

@johnnagro
Copy link

@justinhynes justinhynes changed the title build: demonstrate using localhost.stage.edx.org [Do Not Merge] build: demonstrate using localhost.stage.edx.org Sep 5, 2023
@justinhynes
Copy link
Contributor

I followed up with @adamstankiewicz and this PR can be closed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants