Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reskin of Profile MFE main page #1114

Merged
merged 12 commits into from
Nov 18, 2024

refactor: refactored code according to requested changes

3eaa383
Select commit
Loading
Failed to load commit list.
Merged

feat: reskin of Profile MFE main page #1114

refactor: refactored code according to requested changes
3eaa383
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 1s

68.72% (+1.59%) compared to a134083

View this Pull Request on Codecov

68.72% (+1.59%) compared to a134083

Details

Codecov Report

Attention: Patch coverage is 73.04075% with 86 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (a134083) to head (3eaa383).
Report is 21 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/profile-v2/data/services.js 11.11% 45 Missing and 3 partials ⚠️
src/profile-v2/forms/ProfileAvatar.jsx 73.52% 9 Missing ⚠️
src/profile-v2/data/sagas.js 82.22% 7 Missing and 1 partial ⚠️
src/index.jsx 0.00% 7 Missing ⚠️
src/profile-v2/ProfilePage.jsx 90.47% 4 Missing ⚠️
src/data/reducers.js 0.00% 2 Missing ⚠️
src/data/sagas.js 0.00% 2 Missing ⚠️
src/profile-v2/NotFoundPage.jsx 0.00% 2 Missing ⚠️
src/profile-v2/data/constants.js 0.00% 2 Missing ⚠️
src/profile-v2/CertificateCard.jsx 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           2u-main    #1114      +/-   ##
===========================================
+ Coverage    67.12%   68.72%   +1.59%     
===========================================
  Files           51       71      +20     
  Lines          864     1180     +316     
  Branches       179      251      +72     
===========================================
+ Hits           580      811     +231     
- Misses         274      355      +81     
- Partials        10       14       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov