Bw/routes #42
Merged
Bw/routes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 43.79% 42.94% -0.85%
==========================================
Files 49 53 +4
Lines 306 312 +6
Branches 90 90
==========================================
Hits 134 134
- Misses 172 178 +6
☔ View full report in Codecov by Sentry. |
| onClose={null} | ||
| hasCloseButton={false} | ||
| title={title} | ||
| modalBodyClassName="content-body" |
There was a problem hiding this comment.
I have been using modal footerNode attribute. We probably need to do css work around to have footer as children instead.
leangseu-edx
approved these changes
Sep 25, 2023
muselesscreator
force-pushed
the
bw/routes
branch
from
b935d47 to
c4504c0
Compare
leangseu-edx
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds separate routes for the different assessment types and the xblock view, and also separates raw from "embedded" views, providing a mechanism for displaying views without their embed context.