feat: interactive rubric #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muselesscreator
suggested changes
Sep 11, 2023
leangseu-edx
force-pushed
the
lk/rubric-interactive
branch
from
1087da2 to
13008ea
Compare
|
If introducing api actions separated from the fetch functionality, plz rename |
src/components/Rubric/CriterionContainer/RadioCriterion.test.jsx
Outdated
Show resolved
Hide resolved
|
V much appreciate the updates! Plz take a look at remaining comments and merge conflicts and we will see if we can get merged tomorrow. As a note: having component hooks in ts is still a step beyond current community plans, but is a small/similar enough chunk of code that is still contract based, so I think still brings enough value to include as experiment |
leangseu-edx
force-pushed
the
lk/rubric-interactive
branch
3 times, most recently
from
4c40485 to
ee48348
Compare
muselesscreator
approved these changes
Sep 19, 2023
chore: remove smart camelize chore: update logic and rewrite in typescript chore: revert back to jsx chore: rename api.ts to data.ts chore: update test
leangseu-edx
force-pushed
the
lk/rubric-interactive
branch
from
ee48348 to
cd03471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.