Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #22

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Aug 22, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft August 22, 2023 12:26
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f5e7ba4) 22.22% compared to head (e1d9e4d) 22.22%.
Report is 3 commits behind head on master.

❗ Current head e1d9e4d differs from pull request most recent head 9844229. Consider uploading reports for the commit 9844229 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   22.22%   22.22%           
=======================================
  Files          50       50           
  Lines         324      324           
  Branches       87       87           
=======================================
  Hits           72       72           
  Misses        252      252           
Files Changed Coverage Δ
src/App.jsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch from 6dfd7e0 to 95581ad Compare August 28, 2023 12:10
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 28, 2023 12:14
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Aug 28, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch from e1d9e4d to 142b09d Compare August 30, 2023 12:09
@muselesscreator muselesscreator merged commit 868c4d0 into openedx:master Sep 11, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants