chore: fix rich text editor

openedx · Sep 22, 2023 · 9b20948 · 9b20948
1 parent f70220e
commit 9b20948
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 11 deletions.
diff --git a/src/components/TextResponse/RichTextEditor.jsx b/src/components/TextResponse/RichTextEditor.jsx
@@ -31,10 +31,6 @@ const RichTextEditor = ({
     toolbar: 'formatselect | bold italic underline | link blockquote image | numlist bullist outdent indent | strikethrough | code | undo redo',
   };
 
-  const handleChange = (e) => {
-    onChange(e.target.getContent());
-  };
-
   return (
     <div className="form-group">
       <label htmlFor="rich-text-response">
@@ -53,7 +49,7 @@ const RichTextEditor = ({
           plugins: 'code image link lists',
           ...extraConfig,
         }}
-        onChange={handleChange}
+        onEditorChange={onChange}
         disabled={disabled}
       />
     </div>

diff --git a/src/components/TextResponse/RichTextEditor.test.jsx b/src/components/TextResponse/RichTextEditor.test.jsx
@@ -18,7 +18,7 @@ describe('<RichTextEditor />', () => {
     optional: true,
     disabled: false,
     value: 'value',
-    onChange: jest.fn(),
+    onChange: jest.fn().mockName('onChange'),
   };
 
   it('render optional', () => {

diff --git a/src/components/TextResponse/__snapshots__/RichTextEditor.test.jsx.snap b/src/components/TextResponse/__snapshots__/RichTextEditor.test.jsx.snap
@@ -28,7 +28,7 @@ exports[`<RichTextEditor /> render disabled 1`] = `
       }
     }
     name="rich-text-response"
-    onChange={[Function]}
+    onEditorChange={[MockFunction onChange]}
     value="value"
   />
 </div>
@@ -61,7 +61,7 @@ exports[`<RichTextEditor /> render optional 1`] = `
       }
     }
     name="rich-text-response"
-    onChange={[Function]}
+    onEditorChange={[MockFunction onChange]}
     value="value"
   />
 </div>
@@ -94,7 +94,7 @@ exports[`<RichTextEditor /> render required 1`] = `
       }
     }
     name="rich-text-response"
-    onChange={[Function]}
+    onEditorChange={[MockFunction onChange]}
     value="value"
   />
 </div>

diff --git a/src/views/SubmissionView/SubmissionContent.jsx b/src/views/SubmissionView/SubmissionContent.jsx
@@ -42,7 +42,7 @@ const SubmissionContent = ({
           <TextResponse
             submissionConfig={oraConfigData.submissionConfig}
             value={submission.response.textResponses[index]}
-            onChange={(value) => onTextResponseChange(value, index)}
+            onChange={onTextResponseChange(index)}
           />
         </div>
       ))}

diff --git a/src/views/SubmissionView/hooks.js b/src/views/SubmissionView/hooks.js
@@ -24,7 +24,7 @@ const useSubmissionViewHooks = () => {
     }
   }, [pageData?.submission]);
 
-  const onTextResponseChange = (textResponse, index) => {
+  const onTextResponseChange = (index) => (textResponse) => {
     dispatchSubmission({
       response: {
         ...submission.response,