fix: peer review bug (#261)

* fix: resolve ORA peer review issue * fix: resolve visual glitch with validateBeforeConfirmation function * fix: update StepProgressIndicator Component
openedx · Dec 16, 2024 · 5dca149 · 5dca149
1 parent ad92c37
commit 5dca149
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/StepProgressIndicator/index.jsx b/src/components/StepProgressIndicator/index.jsx
@@ -53,7 +53,7 @@ const StepProgressIndicator = ({ step }) => {
     && !(step === stepNames.peer && stepInfo[step].isWaitingForSubmissions)
     && !(step === stepNames.studentTraining && needed === done);
 
-  if (stepNames.peer === step && done >= needed) {
+  if (loadNextAction?.action && stepNames.peer === step && done >= needed) {
     loadNextAction.action.labels.default = formatMessage(messages.gradeNextPeerOptional);
   }
   return (

diff --git a/src/views/SubmissionView/hooks/useSubmissionValidationStatus.js b/src/views/SubmissionView/hooks/useSubmissionValidationStatus.js
@@ -35,8 +35,8 @@ const useSubmissionStatuses = (textResponses, uploadedFiles) => {
     }
     const calcFileUploadIsRequired = submissionConfig.fileResponseConfig.required && !uploadedFiles.length;
     setFileUploadIsRequired(calcFileUploadIsRequired);
+    setPromptStatuses(retrievePromptsSubmissionStatus);
     if (containsInvalidPrompts || (submissionConfig.fileResponseConfig.required && !uploadedFiles.length)) {
-      setPromptStatuses(retrievePromptsSubmissionStatus);
       return false;
     }