-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update gating for chat component #1550
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -175,6 +175,7 @@ initialize({ | |
CHAT_RESPONSE_URL: process.env.CHAT_RESPONSE_URL || null, | ||
PRIVACY_POLICY_URL: process.env.PRIVACY_POLICY_URL || null, | ||
SHOW_UNGRADED_ASSIGNMENT_PROGRESS: process.env.SHOW_UNGRADED_ASSIGNMENT_PROGRESS || false, | ||
ENABLE_XPERT_AUDIT: process.env.ENABLE_XPERT_AUDIT || false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Codecov seems to be unhappy with these lines not being covered, not sure we need (or are planning on) testing on these though? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These aren't normally tested as part of unit tests! |
||
}, 'LearnerAppConfig'); | ||
}, | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: this is just pulled from here right? https://github.com/openedx/edx-platform/blob/394a459dec831b9d306f4c1a09b7d9ece1a97388/common/djangoapps/course_modes/models.py#L208 Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!