Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optimizely tracking for prequery search #941

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Feb 6, 2024

Description

Adds Optimizely handler to track prequery suggestions in search box. To confirm that the optimizely experiment is active and event is triggered, the event can be seen in the console.

Optimizely Development Prequery Search experiment settings:
https://app.optimizely.com/v2/projects/1765060276/experiments/27801570015/api_names

Screen.Recording.2024-02-15.at.5.24.43.PM.mov

This work is dependent on the code changes in frontend-enterprise.

JIRA

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (1aacf4d) 83.12%.
Report is 157 commits behind head on master.

Files Patch % Lines
src/components/search/Search.jsx 0.00% 4 Missing ⚠️
src/index.jsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   84.87%   83.12%   -1.75%     
==========================================
  Files         320      344      +24     
  Lines        6399     7432    +1033     
  Branches     1552     1817     +265     
==========================================
+ Hits         5431     6178     +747     
- Misses        941     1216     +275     
- Partials       27       38      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/index.jsx Outdated Show resolved Hide resolved
@katrinan029 katrinan029 requested a review from kiram15 February 16, 2024 02:43
@katrinan029 katrinan029 marked this pull request as ready for review February 16, 2024 02:49
@katrinan029 katrinan029 requested a review from a team February 16, 2024 02:53
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test to check to see if the events were properly pushed? And to make sure we're not doing it for people not in the experiment?

@katrinan029 katrinan029 requested a review from kiram15 February 20, 2024 21:15
@katrinan029
Copy link
Contributor Author

Should we add a test to check to see if the events were properly pushed? And to make sure we're not doing it for people not in the experiment?

the event has a test in the hooks file located here: https://github.com/openedx/frontend-app-learner-portal-enterprise/blob/master/src/components/course/data/tests/hooks.test.jsx#L476

and the rest of the tests are in the frontend-enterprise file here: https://github.com/openedx/frontend-enterprise/pull/373/files#diff-a7b68afa7b3c0021be0ca7641ecc0f25aeea26e6185bdaba70877d1075772efe

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@katrinan029 katrinan029 merged commit fc42338 into master Feb 22, 2024
5 of 7 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8333 branch February 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants