-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add optimizely tracking for prequery search #941
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 84.87% 83.12% -1.75%
==========================================
Files 320 344 +24
Lines 6399 7432 +1033
Branches 1552 1817 +265
==========================================
+ Hits 5431 6178 +747
- Misses 941 1216 +275
- Partials 27 38 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test to check to see if the events were properly pushed? And to make sure we're not doing it for people not in the experiment?
the event has a test in the and the rest of the tests are in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
Description
Adds Optimizely handler to track prequery suggestions in search box. To confirm that the optimizely experiment is active and event is triggered, the event can be seen in the console.
Optimizely Development Prequery Search experiment settings:
https://app.optimizely.com/v2/projects/1765060276/experiments/27801570015/api_names
Screen.Recording.2024-02-15.at.5.24.43.PM.mov
This work is dependent on the code changes in frontend-enterprise.
JIRA
For all changes
Only if submitting a visual change