Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node packages for prequery search #938

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Feb 1, 2024

Bumping packages version for the work related to prequery search results in this PR openedx/frontend-enterprise#371

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review February 1, 2024 21:05
@katrinan029 katrinan029 requested a review from a team February 1, 2024 21:06
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all of them are properly published on lerna, this looks gtg! (pending tests)

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (a17b66f) 84.36%.
Report is 140 commits behind head on master.

Files Patch % Lines
src/components/academies/AcademyContentCard.jsx 65.45% 18 Missing and 1 partial ⚠️
src/components/app/App.jsx 0.00% 6 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/app/EnterpriseAppPageRoutes.jsx 0.00% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
src/components/academies/data/hooks.js 86.20% 4 Missing ⚠️
src/components/course/data/hooks.jsx 94.02% 4 Missing ⚠️
...ourse-header/data/hooks/useCourseRunCardAction.jsx 50.00% 3 Missing ⚠️
...onents/enterprise-user-subsidy/data/hooks/hooks.js 90.32% 3 Missing ⚠️
...c/components/enterprise-user-subsidy/data/utils.js 94.82% 3 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   84.87%   84.36%   -0.52%     
==========================================
  Files         320      342      +22     
  Lines        6399     7373     +974     
  Branches     1552     1814     +262     
==========================================
+ Hits         5431     6220     +789     
- Misses        941     1119     +178     
- Partials       27       34       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 changed the title chore: update node packages for prequery search feature chore: update node packages for prequery search Feb 1, 2024
@katrinan029 katrinan029 merged commit d0b9fda into master Feb 1, 2024
5 of 6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/dependency-bump branch February 1, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants