Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing outdated prequery optimizely code #1179

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 11, 2024

Since we have concluded the pre-query Optimizely experiment, we want to remove the outdated code.
Jira ticket

To properly test this ticket, you need to check out this branch and also kiram15/ENT-9480 from frontend-enterprise. Then, you need to make sure that repository is pulling your local version of frontend-enterprise my creating a file called module.config.js with this content:

module.exports = {
localModules: [
{
moduleName: '@edx/frontend-enterprise-catalog-search',
dir: '../frontend-enterprise/packages/catalog-search',
dist: 'src',
},
{
moduleName: '@edx/frontend-enterprise-utils',
dir: '../frontend-enterprise/packages/utils',
dist: 'src',
}
],
};

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (bd4087e) to head (c754070).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   88.36%   88.40%   +0.04%     
==========================================
  Files         396      396              
  Lines        8404     8390      -14     
  Branches     2062     2016      -46     
==========================================
- Hits         7426     7417       -9     
+ Misses        935      931       -4     
+ Partials       43       42       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit 22c26df into master Sep 16, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9480 branch September 16, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants