Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use browserslist-config [Sumac backport] #524

Conversation

arbrandes
Copy link
Contributor

@arbrandes arbrandes commented Dec 6, 2024

(This is a backport of #523 to Sumac.)

We were installing browserslist-config but not declaring it. This had the effect that webpack - and likely others - were not using it.

@arbrandes arbrandes requested a review from a team as a code owner December 6, 2024 13:23
@arbrandes arbrandes changed the title fix: Use browserslist-config fix: Use browserslist-config [Sumac backport] Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/sumac.master@261448d). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/sumac.master     #524   +/-   ##
============================================================
  Coverage                             ?   97.40%           
============================================================
  Files                                ?      157           
  Lines                                ?     1389           
  Branches                             ?      231           
============================================================
  Hits                                 ?     1353           
  Misses                               ?       34           
  Partials                             ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We were installing browserslist-config but not declaring it.  This had
the effect that webpack - and likely others - were not using it.
@arbrandes arbrandes force-pushed the fix-browserslist-config-sumac branch from 1485259 to 8f67835 Compare December 6, 2024 13:32
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@arbrandes arbrandes merged commit 8e0e217 into openedx:open-release/sumac.master Dec 6, 2024
7 checks passed
@arbrandes arbrandes deleted the fix-browserslist-config-sumac branch December 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants