Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if support page is not set, help button does not appears in header UPDATED #478

Closed
wants to merge 2 commits into from

Conversation

lkatsikaris
Copy link

Fix: if the support page is not set, the help button does not appear in the header

Fixes #373

What changed?

  • If the SUPPORT PAGE variable is not set or is empty, the help button does not appear in the header nav.

image

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

@lkatsikaris lkatsikaris requested a review from a team as a code owner October 16, 2024 14:46
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @lkatsikaris!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@MaxFrank13
Copy link
Member

MaxFrank13 commented Oct 21, 2024

Hey @lkatsikaris 👋 Unfortunately, your branch is out of date with master. You'll need to pull the latest changes from master and then start a new branch from there. For example, if you look at the current directory structure of LearnerDashboardHeader in master, it's slightly different than what you have on your branch. As a result, the code you are modifying actually no longer exists on the master branch.

It's also worth mentioning that someone else has also submitted a PR to fix this: #469. Perhaps we can consolidate efforts into one PR?

@lkatsikaris
Copy link
Author

Hey @lkatsikaris 👋 Unfortunately, your branch is out of date with master. You'll need to pull the latest changes from master and then start a new branch from there. For example, if you look at the current directory structure of LearnerDashboardHeader in master, it's slightly different than what you have on your branch. As a result, the code you are modifying actually no longer exists on the master branch.

It's also worth mentioning that someone else has also submitted a PR to fix this: #469. Perhaps we can consolidate efforts into one PR?

Hi @MaxFrank13, thanks for the response! If that PR is about to be approved, we can continue with it!

@itsjeyd
Copy link

itsjeyd commented Oct 24, 2024

Hi @lkatsikaris and @MaxFrank13, it sounds like we can close this PR? I'll do that now but please reopen if I missed something. Thanks!

@itsjeyd itsjeyd added the duplicate This issue or pull request already exists elsewhere label Oct 24, 2024
@itsjeyd
Copy link

itsjeyd commented Oct 24, 2024

Duplicate of #469.

@itsjeyd itsjeyd closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists elsewhere open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

Don't show help button if no support page is configured
4 participants