[Quince backport] Sync with master #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brian Smith <[email protected]>
Co-authored-by: Mena Hassan <[email protected]>
There are multiple places where attributes of the object provided by `usePaintedDoorExperimentContext()` are assumed to exist. This provides default (null) values for those attributes when creating the context.
25 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #243 +/- ##
=============================================================
Coverage ? 96.36%
=============================================================
Files ? 194
Lines ? 1841
Branches ? 324
=============================================================
Hits ? 1774
Misses ? 62
Partials ? 5 ☔ View full report in Codecov by Sentry. |
24 tasks
|
@arbrandes I trust you can review and merge anything going into a stable release yourself so I'm not adding these to our board for review. |
arbrandes
force-pushed
the
quince-sync
branch
from
ec2431b to
231a188
Compare
|
Waiting for #237 to land before updating and merging. |
arbrandes
force-pushed
the
quince-sync
branch
from
231a188 to
ad25abc
Compare
|
Actually, there were some JS config changes merged to master that I don't think we need, so I'll merge master from before those, and backport future fixes (such as #237) individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync up
quince.masterwith the latestmaster. This is a new MFE for Quince, so we'll want all the latest fixes.