Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recommendations card design and painted door eventing #203

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

syedsajjadkazmii
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii commented Sep 6, 2023

  • Fixed recommendations card design
  • Fixed eventing issue with recommendations painted door experiment

Recommendations Panel Before:

Screenshot 2023-09-06 at 6 52 20 PM

Recommendations Panel After:

Screenshot 2023-09-06 at 6 53 10 PM

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2e09d36) 96.46% compared to head (fc885d0) 96.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         195      195           
  Lines        1839     1839           
  Branches      322      322           
=======================================
  Hits         1774     1774           
  Misses         60       60           
  Partials        5        5           
Files Changed Coverage Δ
src/widgets/RecommendationsPaintedDoorBtn/track.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@zainab-amir zainab-amir merged commit 0f24d3a into master Sep 6, 2023
@zainab-amir zainab-amir deleted the sajjad/fix-eventing-and-design branch September 6, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants