Bulk mgmt tab fix (#158)

* fix bulk management tab * fix status alert prop * shorthand fragment to make ci happy
openedx · Dec 16, 2020 · cc01ab0 · cc01ab0
1 parent 8881e62
commit cc01ab0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/components/Gradebook/BulkManagement.jsx b/src/components/Gradebook/BulkManagement.jsx
@@ -7,7 +7,6 @@ import {
   Button,
   StatusAlert,
   Table,
-  Tab,
 } from '@edx/paragon';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { faDownload } from '@fortawesome/free-solid-svg-icons';
@@ -84,15 +83,15 @@ export class BulkManagement extends React.Component {
 
   render() {
     return (
-      <Tab eventKey="bulk_management" title="Bulk Management">
+      <div>
         <h4>Use this feature by downloading a CSV for bulk management,
           overriding grades locally, and coming back here to upload.
         </h4>
         <form ref={this.fileFormRef} action={this.props.gradeExportUrl} method="post">
           <StatusAlert
             alertType="danger"
             dialog={this.props.bulkImportError}
-            open={this.props.bulkImportError}
+            isOpen={this.props.bulkImportError}
             dismissible={false}
           />
           <StatusAlert
@@ -151,7 +150,7 @@ export class BulkManagement extends React.Component {
           ]}
           className="table-striped"
         />
-      </Tab>
+      </div>
     );
   }
 }

diff --git a/src/components/Gradebook/index.jsx b/src/components/Gradebook/index.jsx
@@ -385,10 +385,12 @@ export default class Gradebook extends React.Component {
               </Tab>
               {this.props.showBulkManagement
                 && (
-                <BulkManagement
-                  courseId={this.props.courseId}
-                  gradeExportUrl={this.props.gradeExportUrl}
-                />
+                <Tab eventKey="bulk_management" title="Bulk Management">
+                  <BulkManagement
+                    courseId={this.props.courseId}
+                    gradeExportUrl={this.props.gradeExportUrl}
+                  />
+                </Tab>
                 )}
             </Tabs>
           </div>