Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify learner email belongs to org #1356

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

Description

Adds a check for csv upload to verify that the emails belong to a learner in the org.
https://2u-internal.atlassian.net/browse/ENT-9695

Screen.Recording.2024-11-19.at.7.57.35.PM.mov

Test

  1. visit link https://localhost.stage.edx.org:1991/alc-general/admin/people-management and create a group
  2. upload a csv (you can create your own or use this file testaccountcsv.csv) and verify that the error text and error card appear.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (3bb7650) to head (45f81a1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ents/learner-credit-management/cards/data/utils.js 90.90% 1 Missing ⚠️
...dit-management/data/hooks/useEnterpriseLearners.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
+ Coverage   85.53%   85.55%   +0.01%     
==========================================
  Files         601      603       +2     
  Lines       13236    13268      +32     
  Branches     2792     2793       +1     
==========================================
+ Hits        11322    11352      +30     
- Misses       1848     1850       +2     
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 marked this pull request as ready for review November 20, 2024 15:04
@katrinan029 katrinan029 merged commit c9bd93f into master Nov 26, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9695 branch November 26, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants