Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh group list after adding group #1349

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

marlonkeating
Copy link
Contributor

@marlonkeating marlonkeating commented Nov 15, 2024

Jira Ticket

Testing

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@marlonkeating marlonkeating marked this pull request as ready for review November 15, 2024 15:15
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (5d259ea) to head (4d9d9fb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
- Coverage   85.56%   85.53%   -0.03%     
==========================================
  Files         601      601              
  Lines       13234    13236       +2     
  Branches     2750     2792      +42     
==========================================
- Hits        11324    11322       -2     
- Misses       1845     1848       +3     
- Partials       65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Although the new group appears on the people manage page after it's created, the number of members shows 0 (see recording).

Screen.Recording.2024-11-21.at.10.45.46.AM.mov

Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

fix: Invalidate groups query after new members are invited
@marlonkeating marlonkeating merged commit 3bb7650 into master Nov 22, 2024
4 checks passed
@marlonkeating marlonkeating deleted the mkeating/ENT-9694 branch November 22, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants