Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filtering and search to budget landing page #1180

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Mar 7, 2024

Description

Adds filtering and search functionality to the budget landing page by putting the budget cards into a DataTable.

https://2u-internal.atlassian.net/browse/ENT-8502

UI

before after
Screenshot 2024-03-07 at 11 20 24 AM Screenshot 2024-03-07 at 11 16 23 AM
Screen.Recording.2024-03-05.at.11.27.21.PM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review March 7, 2024 19:22
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (7c27163) to head (3dc16f7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
+ Coverage   85.36%   85.38%   +0.01%     
==========================================
  Files         498      498              
  Lines       10854    10862       +8     
  Branches     2289     2290       +1     
==========================================
+ Hits         9266     9274       +8     
  Misses       1544     1544              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 requested a review from a team March 7, 2024 19:40
@katrinan029 katrinan029 force-pushed the knguyen2/ent-8502 branch 2 times, most recently from 069de31 to 62910da Compare March 8, 2024 16:25
@katrinan029 katrinan029 merged commit 135cb6e into master Mar 8, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8502 branch March 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants