-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display search result cards in catalog tab #1059
Merged
Merged
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cfc8972
feat: display search result cards in catalog tab
katrinan029 853811c
fix: failing test in BudgetDetailPage
katrinan029 2a94621
fix: replace word register with enroll
katrinan029 3689f23
fix: implemented reviewer comments
katrinan029 c5f3d6e
fix: lint error
katrinan029 4695894
chore: rebase
katrinan029 af78b0d
fix: lint error
katrinan029 db847ca
feat: added policy's catalog uuid to search filter
katrinan029 2c7bd80
fix: failing test
katrinan029 08e54d4
fix: refactored based on reviewer feedback
katrinan029 f95d489
fix: lint error
katrinan029 94bf5ea
fix: refactored code to include new api field and updated test
katrinan029 284eade
fix: removing unused prop in test
katrinan029 491fc21
Merge remote-tracking branch 'origin' into knguyen2/ENT-7591
katrinan029 f621880
fix: refactored
katrinan029 5a56945
fix: search filters
katrinan029 8b42f26
chore: refactored
katrinan029 46a1ab8
chore: rebase
katrinan029 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
const CARD_TEXT = { | ||
BADGE: { | ||
course: 'Course', | ||
execEd: 'Executive Education', | ||
}, | ||
BUTTON_ACTION: { | ||
viewCourse: 'View Course', | ||
katrinan029 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
assign: 'Assign', | ||
}, | ||
ENROLLMENT: { | ||
text: 'Learner must enroll by', | ||
}, | ||
PRICE: { | ||
subText: 'Per learner price', | ||
}, | ||
}; | ||
|
||
export default CARD_TEXT; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these images are intended to be the default card image, not a fallback logo image. Also, the fallback card image should not be hosted within the the MFE itself as it should be pulled from
@edx/brand
instead (docs):Importing from
@edx/brand
ensures the fallback image for cards are consistent for the@edx/brand-edx.org
theme across applications.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! We don't need a default logo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel we do, but could convinced otherwise. The
fallbackSrc
is important because without it, it messes up the card grid with one or more cards with differing heights without the image. Having a missing logo image doesn't affect the card heights in the same way, so having a fallback isn't as important.