Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: iterate on django admin fields for restricted runs #974

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

pwnage101
Copy link
Contributor

@pwnage101 pwnage101 commented Oct 11, 2024

ENT-9569

Screenshots

What a ContentMetadata COURSE looks like if it has restricted versions:

Screenshot 2024-10-11 at 12 10 49 PM

What a ContentMetadata RUN looks like if it is restricted and allowed by one or more catalog query:

Screenshot 2024-10-11 at 12 11 38 PM

Comment on lines -107 to +121
return _html_list_from_objects(restricted_courses, "admin:catalog_contentmetadata_change")
return _html_list_from_objects(restricted_courses, "admin:catalog_restrictedcoursemetadata_change")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this PR also fixes a bug from the previous PR where we display an object, but link to the wrong model.

@pwnage101 pwnage101 force-pushed the pwnage101/ENT-9569-3 branch from 0ded902 to a5d7d51 Compare October 11, 2024 19:35
@pwnage101 pwnage101 enabled auto-merge October 11, 2024 19:35
@pwnage101 pwnage101 merged commit 2766981 into master Oct 15, 2024
4 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-9569-3 branch October 15, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants