feat: take exec ed course data from course run instead of additional_metadata attempt 3 #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlonkeating
commented
Oct 9, 2024
| based on normalized_metadata's enroll_by_date | ||
| """ | ||
| enroll_by_deadline = course_json_metadata.get('normalized_metadata')['enroll_by_date'] | ||
| enroll_by_deadline_timestamp = parse_datetime(enroll_by_deadline).timestamp() |
There was a problem hiding this comment.
This is the one line fixed from https://github.com/openedx/enterprise-catalog/pull/912
brobro10000
reviewed
Oct 9, 2024
There was a problem hiding this comment.
One clarifying question from me, relates to @brobro10000's other comments. Thanks for calling out the specific fix in this PR compared to the previous attempt 😄
marlonkeating
force-pushed
the
mkeating/ENT-8248-3
branch
from
58a0ffe to
3ac45e0
Compare
brobro10000
approved these changes
Oct 10, 2024
| 'weeks_to_complete': weeks_to_complete, | ||
| 'outcome': outcome, | ||
| 'advertised_course_run': advertised_course_run, | ||
| 'content_price': content_price |
…metadata attempt 3 fix: use content_price for populating price csv column refactor: rename variable for clarity
marlonkeating
force-pushed
the
mkeating/ENT-8248-3
branch
from
3ac45e0 to
6c1cd55
Compare
adamstankiewicz
approved these changes
Oct 10, 2024
This was referenced Oct 18, 2024
revert: feat: take exec ed course data from course run instead of additional_metadata attempt 3
#981
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates references for Exec Ed courses originally contained in the
additional_metadatafield, to now be taken from course runs. Fixing datetime parsing issue that was found in earlier attempt #912, by incorporating fixes made in #958Ticket Link
ENT-8248: update custom logic for non-ocm courses in enterprise-catalog
Outstanding Questions
Post-review