Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set DJANGO_SETTINGS_MODULE in Dockerfile #726

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: set DJANGO_SETTINGS_MODULE in Dockerfile #726

merged 2 commits into from
Nov 29, 2023

Conversation

johnnagro
Copy link
Contributor

@johnnagro johnnagro commented Nov 29, 2023 •
edited
Loading

Description

as seen here https://github.com/openedx/enterprise-access/blob/main/Dockerfile#L66

k8s deployment issue:

...
  File "/venv/lib/python3.8/site-packages/django/conf/__init__.py", line 82, in _setup
    raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: Requested settings, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.

pwnage101
pwnage101 requested changes Nov 29, 2023
View reviewed changes
Dockerfile Outdated
@@ -46,6 +46,7 @@ RUN locale-gen en_US.UTF-8
ENV LANG en_US.UTF-8
ENV LANGUAGE en_US:en
ENV LC_ALL en_US.UTF-8
ENV DJANGO_SETTINGS_MODULE enterprise_access.settings.production
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copypasta (enterprise_access), i'm guessing?

@johnnagro johnnagro merged commit 0934881 into master Nov 29, 2023
4 checks passed
@johnnagro johnnagro deleted the johnnagro/catalog-k8s/2 branch November 29, 2023 19:56
irfanuddinahmad pushed a commit that referenced this pull request Jul 24, 2024
@johnnagro
fix: set DJANGO_SETTINGS_MODULE in Dockerfile (#726)
bc8b37c 
* fix: set DJANGO_SETTINGS_MODULE in Dockerfile

* fix: set DJANGO_SETTINGS_MODULE in Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwnage101 pwnage101 pwnage101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnagro @pwnage101