Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ADR for academies relationships #712

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

irfanuddinahmad
Copy link
Contributor

Description

This PR adds an ADR for the relationship between academies and content libraries

Ticket Link

ENT-7544

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for writing it! Just one request to give a little more detail around the reasoning for the M2M relationship.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-7544 branch 2 times, most recently from 2ab0445 to 6a614b4 Compare November 15, 2023 09:44
@irfanuddinahmad irfanuddinahmad merged commit b5e17d2 into master Feb 13, 2024
6 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-7544 branch February 13, 2024 13:57
irfanuddinahmad added a commit that referenced this pull request Jul 24, 2024
feat: Added ADR for academies relationships
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants