Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add content_price field to normalized_metadata #703

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Oct 25, 2023

Description

Currently, we add business logic in the frontend apps to find the content price for each course. This PR adds content_price to normalized_metadata to remove that logic from the frontend.

Ticket Link

Link to the associated ticket
JIRA

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katrinan029 katrinan029 merged commit 201b3fe into master Oct 26, 2023
4 of 5 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ENT-7591 branch October 26, 2023 19:42
irfanuddinahmad pushed a commit that referenced this pull request Jul 24, 2024
* feat: add content_price field to normalized_metadata

* fix: refactored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants