chore: remove deprecated code for indexing catalogs for programs #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-7729-2
branch
2 times, most recently
from
bc7a808 to
a6865e8
Compare
pwnage101
changed the title
pwnage101
commented
Oct 4, 2023
Comment on lines
+708
to
+710
| * If a course is part of a program, but only the program is in a given catalog, that catalog will only be indexed as | ||
| part of the program. That means the program will only be searchable via the catalog or customer of that catalog, | ||
| but not the containing course, possibly hiding content from search results that are actually accessible. It might | ||
| be worth re-assessing this logic to determine if it's correct. |
There was a problem hiding this comment.
Adding this documentation is the outcome of our parking lot item from today's standup.
pwnage101
force-pushed
the
pwnage101/ENT-7729-2
branch
2 times, most recently
from
ec3fd7a to
967ab3b
Compare
This is the last cleanup step of ENT-7729 to remove deprecated code which improperly included catalogs in program algolia objects that did not necessarily provide all content within the program. ENT-7729
pwnage101
force-pushed
the
pwnage101/ENT-7729-2
branch
from
967ab3b to
27c342f
Compare
iloveagent57
approved these changes
Oct 6, 2023
adamstankiewicz
approved these changes
Oct 6, 2023
irfanuddinahmad
pushed a commit
that referenced
this pull request
Jul 24, 2024
chore: remove deprecated code for indexing catalogs for programs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last cleanup step of ENT-7729 to remove deprecated code which improperly included catalogs in program algolia objects that did not necessarily provide all content within the program.
ENT-7729