Skip to content

Commit

Permalink
Revert "fix: add more memcache debugging to discovery cache client"
Browse files Browse the repository at this point in the history
This reverts commit 6a15a55.
  • Loading branch information
iloveagent57 committed Oct 2, 2023
1 parent b3849ed commit 7422f75
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions enterprise_catalog/apps/api_client/discovery_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,27 +62,10 @@ def _get_catalog_query_metadata(self, catalog_query):
catalog_query_data = client.get_metadata_by_query(catalog_query)
if not catalog_query_data:
catalog_query_data = []

# cache.add() will not attempt to update the cache if the key specified is already present
# this is fine here, because we know we just encountered a cache miss on our key.
# add() returns a boolean letting us know if it stored anything in the cache
# Debugging: force ignore_exc off to see what exception is getting raise
# on the cache adds.
if hasattr(cache, '_options'):
cache._options['ignore_exc'] = False # pylint: disable=protected-access
cache_add_success = False
try:
cache_add_success = cache.add(
cache_key,
catalog_query_data,
settings.DISCOVERY_CATALOG_QUERY_CACHE_TIMEOUT,
)
except Exception as exc: # pylint: disable=broad-except
LOGGER.exception('Cache add fail %s', exc)
finally:
if hasattr(cache, '_options'):
cache._options['ignore_exc'] = True # pylint: disable=protected-access

cache_add_success = cache.add(cache_key, catalog_query_data, settings.DISCOVERY_CATALOG_QUERY_CACHE_TIMEOUT)
if cache_add_success:
LOGGER.info(
'CatalogQueryDetails: CACHED CatalogQuery metadata with id %s for %s sec',
Expand Down

0 comments on commit 7422f75

Please sign in to comment.