Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for python 3.8 #516

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-20.04]
python-version: ['3.8', '3.12']
python-version: ['3.12']
toxenv: [python, quality]

steps:
Expand Down
7 changes: 4 additions & 3 deletions pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
# SERIOUSLY.
#
# ------------------------------
# Generated by edx-lint version: 5.2.5
# Generated by edx-lint version: 5.3.6
# ------------------------------
[MASTER]
ignore = ,.git,.tox
Expand Down Expand Up @@ -259,6 +259,7 @@ enable =
useless-suppression,
disable =
bad-indentation,
broad-exception-raised,
consider-using-f-string,
duplicate-code,
file-ignored,
Expand Down Expand Up @@ -383,6 +384,6 @@ ext-import-graph =
int-import-graph =

[EXCEPTIONS]
overgeneral-exceptions = Exception
overgeneral-exceptions = builtins.Exception

# 6a5f2b58c0741088bb34597f419f7419e326a841
# 6ba39b4accf3da730ae894307bd8cd4a4e122ab3
4 changes: 2 additions & 2 deletions repo_health/check_renovate.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,6 @@ async def check_renovate(all_results, repo_path, github_repo):
all_results[MODULE_DICT_KEY] = {
'configured': config_exists,
'last_pr': await get_last_pull_date(github_repo) if config_exists else None,
'total_open_prs': total_open_prs if config_exists else None,
'oldest_open_pr_date': oldest_pr_date if config_exists else None,
'total_open_prs': total_open_prs if config_exists else None, # pylint: disable=possibly-used-before-assignment
'oldest_open_pr_date': oldest_pr_date if config_exists else None, # pylint: disable=possibly-used-before-assignment
}
2 changes: 1 addition & 1 deletion repo_health/check_ubuntufiles.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
packages = self._prepare_data(list(packages))
return packages

except Exception as exc: # pylint: disable=useless-suppression
except Exception as exc: # pylint: disable=broad-exception-caught

Check warning on line 235 in repo_health/check_ubuntufiles.py

View check run for this annotation

Codecov / codecov/patch

repo_health/check_ubuntufiles.py#L235

Added line #L235 was not covered by tests
logger.exception("Following error occurred while parsing yml playbook (%s) in configuration repo: %s",
playbook_path, exc)
return []
Expand Down
2 changes: 1 addition & 1 deletion repo_health/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
return all_tags_list[:all_tags_list.index(latest_tag) + 1]
else:
return None
except Exception as ex:
except Exception as ex: # pylint: disable=broad-exception-caught

Check warning on line 139 in repo_health/utils.py

View check run for this annotation

Codecov / codecov/patch

repo_health/utils.py#L139

Added line #L139 was not covered by tests
print(str(ex))
return None

Expand Down
44 changes: 20 additions & 24 deletions requirements/base.txt
Original file line number Diff line number Diff line change
@@ -1,29 +1,27 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
#
aiohttp==3.9.3
aiohappyeyeballs==2.4.0
# via aiohttp
aiohttp==3.10.5
# via
# github-py
# pytest-aiohttp
aiosignal==1.3.1
# via aiohttp
async-timeout==4.0.3
# via aiohttp
attrs==23.2.0
attrs==24.2.0
# via aiohttp
cachetools==5.3.3
cachetools==5.5.0
# via google-auth
certifi==2024.2.2
certifi==2024.7.4
# via requests
charset-normalizer==3.3.2
# via requests
dockerfile==3.3.1
# via -r requirements/base.in
exceptiongroup==1.2.0
# via pytest
frozenlist==1.4.1
# via
# aiohttp
Expand All @@ -32,19 +30,19 @@ gitdb==4.0.11
# via gitpython
github-py @ git+https://github.com/ShineyDev/github.py.git@8e3514010eb35a91e012f2935f48138b3c35cef6
# via -r requirements/github.in
gitpython==3.1.42
gitpython==3.1.43
# via pytest-repo-health
google-auth==2.28.1
google-auth==2.34.0
# via
# google-auth-oauthlib
# gspread
google-auth-oauthlib==1.2.0
google-auth-oauthlib==1.2.1
# via gspread
gspread==5.11.3
# via
# -c requirements/constraints.txt
# -r requirements/base.in
idna==3.6
idna==3.8
# via
# requests
# yarl
Expand All @@ -60,15 +58,15 @@ packaging==21.3
# via
# -c requirements/constraints.txt
# pytest
pluggy==1.4.0
pluggy==1.5.0
# via pytest
pyasn1==0.5.1
pyasn1==0.6.0
# via
# pyasn1-modules
# rsa
pyasn1-modules==0.3.0
pyasn1-modules==0.4.0
# via google-auth
pyparsing==3.1.2
pyparsing==3.1.4
# via packaging
pytest==8.0.2
# via
Expand All @@ -78,29 +76,27 @@ pytest==8.0.2
# pytest-repo-health
pytest-aiohttp==1.0.5
# via pytest-repo-health
pytest-asyncio==0.23.5
pytest-asyncio==0.23.8
# via
# -r requirements/base.in
# pytest-aiohttp
pytest-repo-health==3.0.2
# via -r requirements/base.in
pyyaml==6.0.1
pyyaml==6.0.2
# via
# -r requirements/base.in
# pytest-repo-health
requests==2.31.0
requests==2.32.3
# via requests-oauthlib
requests-oauthlib==1.3.1
requests-oauthlib==2.0.0
# via google-auth-oauthlib
rsa==4.9
# via google-auth
smmap==5.0.1
# via gitdb
toml==0.10.2
# via -r requirements/base.in
tomli==2.0.1
# via pytest
urllib3==2.2.1
urllib3==2.2.2
# via requests
yarl==1.9.4
# via aiohttp
18 changes: 7 additions & 11 deletions requirements/ci.txt
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
#
cachetools==5.3.3
cachetools==5.5.0
# via tox
chardet==5.2.0
# via tox
colorama==0.4.6
# via tox
distlib==0.3.8
# via virtualenv
filelock==3.13.1
filelock==3.15.4
# via
# tox
# virtualenv
Expand All @@ -21,21 +21,17 @@ packaging==21.3
# -c requirements/constraints.txt
# pyproject-api
# tox
platformdirs==4.2.0
platformdirs==4.2.2
# via
# tox
# virtualenv
pluggy==1.4.0
pluggy==1.5.0
# via tox
pyparsing==3.1.2
pyparsing==3.1.4
# via packaging
pyproject-api==1.5.0
# via tox
tomli==2.0.1
# via
# pyproject-api
# tox
tox==4.0.0
# via -r requirements/ci.in
virtualenv==20.25.1
virtualenv==20.26.3
# via tox
8 changes: 8 additions & 0 deletions requirements/common_constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,15 @@ Django<5.0

# elasticsearch>=7.14.0 includes breaking changes in it which caused issues in discovery upgrade process.
# elastic search changelog: https://www.elastic.co/guide/en/enterprise-search/master/release-notes-7.14.0.html
# See https://github.com/openedx/edx-platform/issues/35126 for more info
elasticsearch<7.14.0

# django-simple-history>3.0.0 adds indexing and causes a lot of migrations to be affected
django-simple-history==3.0.0

# Cause: https://github.com/openedx/event-tracking/pull/290
# event-tracking 2.4.1 upgrades to pymongo 4.4.0 which is not supported on edx-platform.
# We will pin event-tracking to do not break existing installations
# This can be unpinned once https://github.com/openedx/edx-platform/issues/34586
# has been resolved and edx-platform is running with pymongo>=4.4.0
event-tracking<2.4.1
Loading
Loading