Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up built in blocks css #35854

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore: clean up built in blocks css #35854

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7efe649
chore: clean up built in blocks css
farhan Nov 15, 2024
ad377dc
chore: Address PR change request
farhan Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions xmodule/static/css-builtin-blocks/AnnotatableBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_AnnotatableBlock {
/* TODO: move top-level variables to a common _variables.scss.
* NOTE: These variables were only added here because when this was integrated with the CMS,
* SASS compilation errors were triggered because the CMS didn't have the same variables defined
* that the LMS did, so the quick fix was to localize the LMS variables not shared by the CMS.
* -Abarrett and Vshnayder
*/
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_AnnotatableBlock .annotatable-wrapper {
position: relative;
}
Expand Down
8 changes: 0 additions & 8 deletions xmodule/static/css-builtin-blocks/HtmlBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_AboutBlock,
.xmodule_display.xmodule_CourseInfoBlock,
.xmodule_display.xmodule_HtmlBlock,
.xmodule_display.xmodule_StaticTabBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_AboutBlock *,
.xmodule_display.xmodule_CourseInfoBlock *,
.xmodule_display.xmodule_HtmlBlock *,
Expand Down
5 changes: 0 additions & 5 deletions xmodule/static/css-builtin-blocks/HtmlBlockEditor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_edit.xmodule_AboutBlock,
.xmodule_edit.xmodule_CourseInfoBlock,
.xmodule_edit.xmodule_HtmlBlock,
.xmodule_edit.xmodule_StaticTabBlock {
}

.xmodule_edit.xmodule_AboutBlock .ui-col-wide,
.xmodule_edit.xmodule_CourseInfoBlock .ui-col-wide,
Expand Down
12 changes: 3 additions & 9 deletions xmodule/static/css-builtin-blocks/LTIBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_LTIBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_LTIBlock h2.problem-header {
display: inline-block;
}

.xmodule_display.xmodule_LTIBlock div.problem-progress {
display: inline-block;
padding-left: calc((var(--baseline)/4));
padding-left: calc((var(--baseline) / 4));
color: #666;
font-weight: 100;
font-size: 1em;
Expand Down Expand Up @@ -57,6 +51,6 @@
}

.xmodule_display.xmodule_LTIBlock div.lti div.problem-feedback {
margin-top: calc((var(--baseline)/4));
margin-bottom: calc((var(--baseline)/4));
margin-top: calc((var(--baseline) / 4));
margin-bottom: calc((var(--baseline) / 4));
}
5 changes: 0 additions & 5 deletions xmodule/static/css-builtin-blocks/PollBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_PollBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
}

@media print {
.xmodule_display.xmodule_PollBlock div.poll_question {
display: block;
Expand Down
7 changes: 1 addition & 6 deletions xmodule/static/css-builtin-blocks/ProblemBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_ProblemBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_ProblemBlock div.problem .choicegroup input + label.choicegroup_correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + label.choicegroup_correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup .choicegroup input + label.choicetextgroup_correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + label.choicetextgroup_correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup .choicegroup input + section.choicetextgroup_correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + section.choicetextgroup_correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicegroup input + label.choicegroup_partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + label.choicegroup_partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup .choicegroup input + label.choicetextgroup_partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + label.choicetextgroup_partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup .choicegroup input + section.choicetextgroup_partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + section.choicetextgroup_partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicegroup input + label.choicegroup_incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + label.choicegroup_incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup .choicegroup input + label.choicetextgroup_incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + label.choicetextgroup_incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup .choicegroup input + section.choicetextgroup_incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .choicetextgroup input + section.choicetextgroup_incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .indicator-container .status.correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .indicator-container .status.partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .indicator-container .status.incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock .problem .capa_inputtype.textline > .incorrect .status .status-icon::after, .xmodule_display.xmodule_ProblemBlock .problem .inputtype.formulaequationinput > .incorrect .status .status-icon::after, .xmodule_display.xmodule_ProblemBlock .problem .capa_inputtype.textline > .partially-correct .status .status-icon::after, .xmodule_display.xmodule_ProblemBlock .problem .inputtype.formulaequationinput > .partially-correct .status .status-icon::after, .xmodule_display.xmodule_ProblemBlock .problem .capa_inputtype.textline > .correct .status .status-icon::after, .xmodule_display.xmodule_ProblemBlock .problem .inputtype.formulaequationinput > .correct .status .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .imageinput.capa_inputtype .correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .imageinput.capa_inputtype .incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .imageinput.capa_inputtype .partially-correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .annotation-input .correct .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .annotation-input .incorrect .status-icon::after, .xmodule_display.xmodule_ProblemBlock div.problem .annotation-input .partially-correct .status-icon::after {
font-family: FontAwesome;
-webkit-font-smoothing: antialiased;
Expand Down Expand Up @@ -901,8 +896,8 @@
}

.xmodule_display.xmodule_ProblemBlock div.problem

var

(
--all-text-inputs

Expand Down
3 changes: 0 additions & 3 deletions xmodule/static/css-builtin-blocks/ProblemBlockEditor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_edit.xmodule_ProblemBlock {
}

.xmodule_edit.xmodule_ProblemBlock .ui-col-wide {
width: 74.46809%;
margin-right: 2.12766%;
Expand Down
5 changes: 0 additions & 5 deletions xmodule/static/css-builtin-blocks/SequenceBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_SequenceBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_SequenceBlock .block-link {
border-left: 1px solid var(--border-color);
display: block;
Expand Down
9 changes: 0 additions & 9 deletions xmodule/static/css-builtin-blocks/VideoBlockDisplay.css
View file
Open in desktop
farhan marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_VideoBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_VideoBlock {
margin-bottom: calc((var(--baseline) * 1.5));
}
Expand Down
3 changes: 0 additions & 3 deletions xmodule/static/css-builtin-blocks/VideoBlockEditor.css
View file
Open in desktop
farhan marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_edit.xmodule_VideoBlock {
}

.xmodule_edit.xmodule_VideoBlock .ui-col-wide {
width: 74.46809%;
margin-right: 2.12766%;
Expand Down
5 changes: 0 additions & 5 deletions xmodule/static/css-builtin-blocks/WordCloudBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_WordCloudBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_WordCloudBlock .input-cloud {
margin: calc((var(--baseline) / 4));
}
Expand Down
Loading