Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrading simple api to drf compatible (6th) . modify_access #35260

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Aug 8, 2024

Issue

Upgrading plain api to DRF compatible.

Post man verification

  1. URL
  2. form-data
    unique_student_identifier= admin
    rolename = staff
    action = revoke
    expected result
    { "unique_student_identifier": "admin", "rolename": "staff", "action": "revoke", "success": "yes" }

For end to end verification

  1. Go to this page
  2. Pass valid username and press Add staff button
Screenshot 2024-08-09 at 11 51 15 AM

@awais786 awais786 changed the title feat: upgrading simple api to drf compatible. feat: upgrading simple api to drf compatible (6th) . modify_access Aug 8, 2024
@awais786 awais786 force-pushed the modify_access-api- branch from 9d586b7 to ed195b2 Compare August 8, 2024 21:23
@awais786
Copy link
Contributor Author

awais786 commented Aug 9, 2024

@feanil Please review.

@awais786 awais786 requested a review from feanil August 9, 2024 21:09
@awais786 awais786 marked this pull request as ready for review August 20, 2024 11:53
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be merged.

@awais786 awais786 merged commit af9ae77 into master Aug 20, 2024
49 checks passed
@awais786 awais786 deleted the modify_access-api- branch August 20, 2024 12:25
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

rediris pushed a commit to gymnasium/edx-platform that referenced this pull request Aug 27, 2024
Agrendalath pushed a commit to open-craft/edx-platform that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants