-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0040] feat: update search index when object tags change #34559
[FC-0040] feat: update search index when object tags change #34559
Conversation
This takes care of updating tags data in search index for both course and library blocks.
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
d474406
to
8fc6c45
Compare
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
) * feat: Update search index when object tags updated * feat: Update index when library block tags change * refactor: Remove extra params * docs: Add new event to hook events docs * feat: Add and use upsert_block_tags_index_docs This takes care of updating tags data in search index for both course and library blocks. * chore: Update openedx-events * fix: Update tests + include course block tags in reindex * feat: Fix static-type issues + adjust tag_object * fix: bug retrieving the Meilisearch API key UID (first time only) * docs: Update comments --------- Co-authored-by: Braden MacDonald <[email protected]>
Description
This PR implements updating search index with object tags whenever they change, based on the new
CONTENT_OBJECT_TAGS_CHANGED
event.Supporting Information
CONTENT_OBJECT_TAGS_CHANGED
signal openedx-events#327Testing Instructions
CONTENT_OBJECT_TAGS_CHANGED
signal openedx-events#327 and make sure it is accessible from your devstack, and install it locallypip uninstall openedx-events
pip install -e path/to/openedx-events/
meilisearch
setup locally, follow the setup instructions here https://github.com/open-craft/tutor-contrib-meilisearchtutor dev run cms bash
and./manage.py cms reindex_studio
Tags
field in the index document for the block has been updated to reflect that changes you made.Prinvate-ref: FAL-3691