-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filtering via filenames in asset list endpoint #33493
Conversation
Thanks for the pull request, @mavidser! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
4a86549
to
effcffc
Compare
Hi @mavidser! Regarding the CLA message above, can you confirm if you're contributing as an individual, or if you're contributing on behalf of an organization? If you're contributing as an individual, please fill out the CLA form as requested. If you are contributing on behalf of an organization, please have your manager reach out to [email protected] to be added to your organization's entity agreement. |
effcffc
to
f87c1a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mavidser 👍 I have left a couple of small suggestions. Otherwise LGTM
- I tested this: I tested this along with feat: Add check to see if assets pre-exist when uploading studio-frontend#384 by uploading files and verifying the errors are generated as expected.
- I read through the code
- I checked for accessibility issues
- Includes documentation
cdf1994
to
fd7b2f4
Compare
@tecoholic Thanks, I've addressed the requested changes and rebased :) |
6ccec06
to
be40224
Compare
be40224
to
f325ef1
Compare
@jristau1984 @cablaa77 Hi this PR along with openedx/studio-frontend#384 should resolve the ticket TNL-10321. Can you kindly review? |
Hi @tecoholic! Just flagging that there's still a failing check :) |
a4bd9b3
to
a56ea0c
Compare
@mphilbrick211 Those seemed to be some transient build errors. Fixed by rebasing :) |
@mphilbrick211 T&L will not be able to review this PR for a while, as we are working on rolling several new features out through this and next month. |
@mphilbrick211, @jristau1984: I can get this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! People have wanted this feature for a while. 😄
@ormsbee I've updated the PR to be much more simplistic. The suggestion to use asset details made sense, so I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits and give a little more detail in your commit message about why this enhancement to the endpoint is useful, i.e. the use case it serves. I'll merge this in the morning. Thank you for your contribution!
This allows clients to check if a file already exist before overwriting the asset with new data. See openedx/studio-frontend#384
224e10c
to
41e3e37
Compare
@ormsbee Ack, have squashed 👍 |
@mavidser 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
This PR adds API changes to support adding asset overwrite confirmation in CMS.
Frontend PR: openedx/studio-frontend#384
JIRA Ticket: TNL-10321
Testing instructions
From
make studio-shell
run:python -Wd -m pytest --ds=cms.envs.test cms/djangoapps/contentstore/views/tests/test_assets.py::UploadTestCase::test_pre_existing_asset