-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creating new enterprise group members endpoint #2270
Conversation
bdc5b56
to
ded0c0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! I think we're just missing the sorting piece since we want the members table to be alphabetized per the design specs. https://www.figma.com/design/eMWRd2jVa4Jqc6y7qrUfaa/Groups-Phase-2?node-id=1193-6018&t=PancQEnrxtpLLI1J-1
9728a87
to
51ae1ad
Compare
3921683
to
2805fd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! let's add the e2e test for the view in edx_platform
f14c1c6
to
bec74f4
Compare
Adding in an endpoint for the data table that is created in this ticket. We will be fetching info about the user (email, joined_org, name) from the enterprise_customer_user, and then fetching the total number of enrollments associated with that enterprise user.
Jira
Members are sorted on name
Testing:
The link is http://localhost:18000/enterprise/api/v1/enterprise-customer-members/{enterprise-uuid}
?user_query=test
to url to make sure it is only filtering for either emails or names that contain the user queryMerge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.