perf: admin perf optimization for course-discovery #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
force-pushed
the
afaq/prod-4225
branch
from
7847892 to
85fd64b
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-4225
branch
from
63bd27e to
811e8f6
Compare
DawoudSheraz
approved these changes
Nov 29, 2024
zawan-ila
approved these changes
Dec 3, 2024
| Prefetch( | ||
| 'type__translations', | ||
| queryset=ProgramTypeTranslation.objects.filter(language_code='en'), | ||
| to_attr='prefetched_translations' |
There was a problem hiding this comment.
Is this Prefetch helpful? I don't see how the prefetched_translations attribute would be accessed?
There was a problem hiding this comment.
Removing this will cause extra queries to fetch options in dropdown on retrieving a single object
There was a problem hiding this comment.
However, I've overridden the formfield_for_foreignkey method now to eliminate the similar queries
| @@ -661,6 +739,14 @@ class PersonAdmin(admin.ModelAdmin): | |||
| readonly_fields = ('uuid',) | |||
| search_fields = ('uuid', 'salutation', 'family_name', 'given_name', 'slug',) | |||
|
|
|||
| def get_queryset(self, request): | |||
| queryset = super().get_queryset(request) | |||
| queryset = queryset.select_related( | |||
There was a problem hiding this comment.
Rather than assigning queryset multiple times, it would be better to chain things like return super.get_queryset.select_related(...)...
| queryset = super().get_queryset(request) | ||
| queryset = queryset.prefetch_related( | ||
| Prefetch('translations', queryset=LevelTypeTranslation.objects.all(), to_attr='translated_names') | ||
| ) |
There was a problem hiding this comment.
[style] Same comment as above
AfaqShuaib09
force-pushed
the
afaq/prod-4225
branch
2 times, most recently
from
7b245bc to
4de5a65
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-4225
branch
from
4de5a65 to
e7986d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4225
This PR adds the
get_querysetmethod to Django Admin registered models. The aim is to optimize database queries and reduce query counts wherever possible by customizing the way queries are fetched in the admin interface. It will avoid unnecessary data fetching and reduce overhead.Screenshots
Before:
After:
Before:
After:
Before:
After:
and so on...