feat: introduce new marketable field #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzawaleed01
commented
Nov 21, 2024
hamzawaleed01
commented
Nov 21, 2024
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
3 times, most recently
from
976ab16 to
6aab3f9
Compare
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
3 times, most recently
from
00cb2c8 to
8c4eef9
Compare
…-9748/introduce-new-marketable-field
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
8c4eef9 to
5bf0947
Compare
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
2 times, most recently
from
53395ab to
062522e
Compare
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
062522e to
1ea33f1
Compare
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
1ea33f1 to
1f33105
Compare
hamzawaleed01
requested review from
macdiesel and
iloveagent57
and removed request for
bcitro
There was a problem hiding this comment.
Left a few comments, mostly minor cleanup nits but also a clarifying question around whether the intent is to support all reviewable states (internal review vs. legal review), or if there's a specific/individual reviewable state that should be used (might be worth verifying).
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
e4945d4 to
a4bc506
Compare
…openedx/course-discovery into ENT-9748/introduce-new-marketable-field
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
8209d41 to
b223606
Compare
…-9748/introduce-new-marketable-field
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
a9d071a to
3114eed
Compare
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
3114eed to
53acdfa
Compare
…-9748/introduce-new-marketable-field
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
2 times, most recently
from
516c906 to
c21efae
Compare
…openedx/course-discovery into ENT-9748/introduce-new-marketable-field
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
c21efae to
2277e78
Compare
AfaqShuaib09
reviewed
Dec 5, 2024
AfaqShuaib09
approved these changes
Dec 5, 2024
…-9748/introduce-new-marketable-field
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
5 times, most recently
from
33a4ba0 to
009f527
Compare
hamzawaleed01
force-pushed
the
ENT-9748/introduce-new-marketable-field
branch
from
009f527 to
a6478a2
Compare
| """ | ||
| if self.is_marketable: | ||
| return self.is_marketable | ||
| is_exec_ed_course = self.course.type.slug == CourseType.EXECUTIVE_EDUCATION_2U |
There was a problem hiding this comment.
As a caution, when filtering on your end, do check for product_source (equals 2u). While it can be added here, it will make things way too specific.
DawoudSheraz
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new marketable field that B2B will use for assigning courses early to their learners.