fix: allow both active and marketable runs in update_course_ai_translations #4441
Conversation
| @@ -51,10 +51,15 @@ def handle(self, *args, **options): | |||
|
|
|||
| course_runs = CourseRun.objects.all() | |||
|
|
|||
| if options['active']: | |||
| if options['active'] and options['marketable']: | |||
| course_runs = CourseRun.objects.filter( | |||
There was a problem hiding this comment.
[curious] Did you try course_runs.active().marketable()?
There was a problem hiding this comment.
Wouldn't that be an intersection of objects instead of Union? 🤔
There was a problem hiding this comment.
Ouch, I did not realize we were doing a union here. Could we try course_runs.marketable().union(course_runs.active())?
There was a problem hiding this comment.
Sounds like we can.
| marketable_course_run.translation_languages, | ||
| [{'code': 'es', 'label': 'Spanish'}] | ||
| ) | ||
| self.assertListEqual(non_active_course_run.translation_languages, []) |
There was a problem hiding this comment.
We should also have a non-marketable but active run with the same assertion.
There was a problem hiding this comment.
the active run is actually the non-marketable. Lemme rename that.
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4175
branch
from
95008a1 to
5aa8c81
Compare
| active_non_marketable_course_run.translation_languages, | ||
| [{'code': 'fr', 'label': 'French'}] | ||
| ) | ||
|
|
There was a problem hiding this comment.
Can we have a non-marketable non-active run and assert that the translation_languages are empty?
| ) | ||
| self.assertListEqual( | ||
| active_non_marketable_course_run.translation_languages, | ||
| [{'code': 'fr', 'label': 'French'}] |
There was a problem hiding this comment.
mock_get_translations returns Spanish, why is this French?
There was a problem hiding this comment.
Ah, the marketable course was also active somehow. Updated the test by adding end date to past.
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4175
branch
2 times, most recently
from
c8a1904 to
f6801e5
Compare
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4175
branch
from
f6801e5 to
2a03ea0
Compare
PROD-4175
Adding an improvement to allow filtering both active and marketable runs.