fix: add setting variable to determine request scheme #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
approved these changes
Sep 9, 2024
pwnage101
approved these changes
Sep 9, 2024
| # a user can fool our server into thinking it was an https connection. | ||
| # See https://docs.djangoproject.com/en/5.1/ref/settings/#secure-proxy-ssl-header | ||
| # for other warnings. | ||
| SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTO', 'https') |
There was a problem hiding this comment.
should we not set this in edx-internal for edX only as the server behind proxy might or might not be applicable for community?
There was a problem hiding this comment.
Maybe. I am just following what edx-platform and enterprise repos do. If platform does the same, we should be OK too?
DawoudSheraz
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD 4118
When we have paginated list endpoints, the "next" page URL is mistakenly HTTP. We suspect this is because the URL is constructed based on the current request scheme. edx-platform seems to workaround this issue by setting SECURE_PROXY_SSL_HEADER which overrides the current request scheme when DRF tries to fetch it to construct a next URL, so this PR is mimicking that behavior.
Enterprise also does the same, and that is where we mostly copy-pasted this PR from.
Internal Slack discussions for more context
https://twou.slack.com/archives/C04ACDVM6A1/p1720630664588599
https://twou.slack.com/archives/C049BVC75J7/p1720627508164049