Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: renovate bot auto merging PRs #4428

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Conversation

hamza-56
Copy link
Contributor

@hamza-56 hamza-56 commented Sep 5, 2024

This PR disables the automerge feature in Renovate Bot configuration. By doing so, Renovate will now assign reviewers and assignees when opening PRs, ensuring proper visibility and involvement in the review process.

When auto merge is enabled, Renovate skips adding reviewers and assignees at PR creation, which can reduce notification noise but may lead to less awareness for important changes.

For reference: Renovate Bot Auto Merge - Assignees and Reviewers

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit type should be chore, not fix.

@hamza-56 hamza-56 force-pushed the hamza/fix-renovate-bot-automerge branch from c1a1bc3 to a444563 Compare September 5, 2024 13:40
Copy link
Contributor

@AfaqShuaib09 AfaqShuaib09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add

"automerge": false

in packageRules

image

@hamza-56 hamza-56 merged commit 54216e9 into master Sep 7, 2024
22 of 26 checks passed
@hamza-56 hamza-56 deleted the hamza/fix-renovate-bot-automerge branch September 7, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants