fix: use correct course_key in case of a key_for_rerun in RCM #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4133
branch
3 times, most recently
from
918f5d3 to
002081d
Compare
| @@ -202,6 +202,8 @@ def create_course_run(self, course, body): | |||
| def get_or_create_course(self, body): | |||
| course_run_key = CourseKey.from_string(body['id']) | |||
| course_key = self.get_course_key_from_course_run_key(course_run_key) | |||
| course_key = (Course.objects.filter(key_for_reruns=course_key).values_list('key', flat=True).first() or | |||
There was a problem hiding this comment.
nit: There should be a comment explaining this scenario in the code. Or better, have an internal or util function to return the course key that considers both scenarios.
| datum = mock_data.COURSES_API_BODY_ORIGINAL | ||
| self.mock_api([datum]) | ||
| course_type = CourseType.objects.get(slug=CourseType.AUDIT) | ||
| course_key = '{org}+{number}'.format(org=datum['org'], number=datum['number']) |
There was a problem hiding this comment.
you can use f-string, no need to use format anymore.
| course_type = CourseType.objects.get(slug=CourseType.AUDIT) | ||
| course_key = '{org}+{number}'.format(org=datum['org'], number=datum['number']) | ||
| course_key_with_key_for_rerun = 'test+key_for_rerun' | ||
| Course.objects.create(partner=self.partner, key=course_key, title='Title', type=course_type) |
There was a problem hiding this comment.
should the first course be created here? Shouldn't only the course with key_for_reruns be created only?
There was a problem hiding this comment.
The scenario we're testing should have a courseA and courseB having key_for_reruns = courseA.key
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4133
branch
3 times, most recently
from
f28d391 to
35d76af
Compare
DawoudSheraz
approved these changes
Aug 19, 2024
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4133
branch
from
35d76af to
c2bf436
Compare
AfaqShuaib09
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4133
Updates the logic behind bringing the courses from studio in case a course is created in Studio and not in Discovery. Previous logic used to create a course_run from Studio into Discovery with whatever was present in the key. In case a course has a value in
key_for_reruns, it used to assign those course_runs to the key equal tokey_for_reruns.Now, it finds if a course has a
key_for_reruns, it will assign this course_run to the correct course that has the customkey_for_rerunsvalue.