Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct request type in anon throttle mixin #4306

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

DawoudSheraz
Copy link
Contributor

@DawoudSheraz DawoudSheraz commented Mar 28, 2024

PROD-3994

Description

Moves request_initialization at start of dispatch so that WSGIRequest --> DRFRequest conversion can take place and request.user does DRF authentication

Testing

  • You need Postman to test this out (for JWT Authentication ease)
  • Go to LMS /admin/oauth2_provider/application/ and setup a new OAuth app. It should be set to Client Credentials public app.
  • Go to postman and make POST request against http://localhost:18000/oauth2/access_token. See pic below for body of request. It should return JWT token
image

@DawoudSheraz DawoudSheraz force-pushed the dsheraz/anon-throttle-fixup branch from 5a995cd to 1e8c2c8 Compare March 29, 2024 05:56
@DawoudSheraz DawoudSheraz marked this pull request as ready for review March 29, 2024 06:02
Copy link
Contributor

@zawan-ila zawan-ila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it out, but looks good!

@DawoudSheraz DawoudSheraz merged commit df07d96 into master Mar 29, 2024
14 checks passed
@DawoudSheraz DawoudSheraz deleted the dsheraz/anon-throttle-fixup branch March 29, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants