fix: typo in make pull_translation for atlas
#4072
Conversation
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
Makefile
Outdated
| @@ -114,7 +114,7 @@ pull_translations: | |||
| atlas pull $(OPENEDX_ATLAS_ARGS) translations/course-discovery/course_discovery/conf/locale:course_discovery/conf/locale | |||
| python manage.py compilemessages | |||
|
|
|||
| @echo "Translations pulled from Transifex and compiled." | |||
| @echo "Translations has been pulled via Atlas and has been compiled." | |||
There was a problem hiding this comment.
grammar nit
| @echo "Translations has been pulled via Atlas and has been compiled." | |
| @echo "Translations have been pulled via Atlas and compiled." |
|
Done @brian-smith-tcril! |
|
@DawoudSheraz I've requested a review and am tagging you on this one because you are listed as "Review required from" on the FC-12/OEP-58/translations project spreadsheet. |
|
Thanks for the reviews @DawoudSheraz and @brian-smith-tcril Would you mind merging this pull request? It's a minor one that's been approved. |
Hi. The branch needs a rebase before it can be merged. |
It doesn't pull from transifex, therefore Transifex shouldn't be mentioned.
|
@DawoudSheraz it's now rebased. |
|
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
It doesn't pull from Transifex, therefore Transifex shouldn't be mentioned.
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.