feat: Update request.py in order to allow Streaming responses #737
Conversation
|
Thanks for the pull request, @TheoBessel! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
|
Hi @TheoBessel! Thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form. |
mphilbrick211
added
the
needs test run
Hi @TheoBessel! Just following up on this. Please let us know when you submit your CLA form. Thanks! |
mphilbrick211
removed
the
needs test run
Hi, @mphilbrick211 thanks for your reply ! I have just submitted my CLA form ! |
TheoBessel
changed the title
Great! The change should be reflected within 24 hours. When you re-run your checks after that, the check next to the CLA requirement should turn green. |
|
@mphilbrick211 Do I have to do anything else now ? |
|
Hi @TheoBessel - I will look into getting the checks re-enabled for you! |
mphilbrick211
added
the
needs test run
@mphilbrick211 Thanks a lot for your help ! |
|
@mphilbrick211 Hello ! Any news ? |
Hi @TheoBessel - thanks for checking in, and for your patience. The checks should be enabled today. Apologies for the delay. |
|
@mphilbrick211 @nedbat Hello ! I've edited my code because it didn't pass the tests. Should I also to edit my commit messages or they are okay ? Let me know. I'll also make a PR on |
|
@mphilbrick211 Hello ! Have you seen my last comment ? |
|
@TheoBessel I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
mphilbrick211
removed
the
needs test run
(Example : needed to build correct ChatGPT XBlocks)
a previous deprecation of this pass-through causes wide-spread consequences.
TheoBessel
force-pushed
the
patch-1
branch
2 times, most recently
from
1306c49 to
bafbb16
Compare
|
@e0d I guess it is good now ? |
… the XBlock Request's form
* chore: Updating Python Requirements * build: Update codecov to use the repository upload token. --------- Co-authored-by: Irtaza Akram <[email protected]> Update request.py
|
@e0d Updated the too long commit message and added some unit tests, it should pass all workflows now (I hope) |
|
@e0d I hope this time it will be good (I removed a test I wrote and that made no sense for Streaming Responses and that was failing because of that) |
mphilbrick211
added
the
needs test run
|
@e0d ? |
|
Can somebody here merge my pull request ? It passes all the checks now. |
mphilbrick211
removed
the
needs test run
|
@TheoBessel - thanks for flagging! I have requested review. |
|
@TheoBessel: Please resolve conflicts and squash your commits and I'll merge. |
I'm sorry, but I don't really know what you're talking about. I don't see any conflicts ans my commits were already amended in order to have correct messages. 🤔 |
|
Ah, sorry, I saw this:
And it didn't click to me that you did a merge instead of a rebase off of master (it's fine, it's just not what I'm used to). I'll squash and merge now. |
|
@TheoBessel 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
ormsbee
changed the title
|
Note for anyone looking at this later: I wasn't paying attention to the top line of the squashed commit message, and merged it in with the I'll make a new PR to bump the version of this package and tag it for PyPI. |
(Example : needed to build correct ChatGPT XBlocks)