Unpin the Django dependency #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It gets pinned in the common constraints file that gets pulled in and we shouldn't pin it any further here. This isn't used for unit testing but is used for things like the docs builds so it should stay up-to-date but is not critical to the functionality of the repo.
For somereason whene pip-compile is compiling requiremnets it's not pulling this environment marker from the upstream dependency so we need to add this depedency of django explicitly for now so that we can restrict it to python<3.9 and have that show up in our requirements files.
feanil
force-pushed
the
feanil/fix_django_dep
branch
from
9dfe6c7 to
e3e059f
Compare
farhan
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were explictly pinning django in django.in which is not necessary and makes it so your dev environment runs with and old version of django. The correct pin already exists in the common-constraints.txt file in edx-lint so we don't need to have an explicit pin here. And for testing, the version is controlled via tox so it doesn't use this. It does effect dev and doc environments though so we should keep it up to date and make it harder to pin it in correctly.