Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve XBlock tutorial sections 1-3 #692

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Nov 18, 2023

  • Simplify XBlock Tutorial introduction section (removed "front matter" section and consolidated on one page; moved "Browsers" under "Overview")

  • Update XBlock Tutorial overview section - particularly, renaming venv to xblock-env to make it clear that you're making a specific venv for this xblock, and also, that venvs can have unique names. I'm open to feedback on the exact name of the env. I'm also open to keeping it venv but explaining more that it's the name we're choosing for the environment (as written I think it can be a bit confusing that we're using venv as a name but also it's the name of the tool)

  • Correct and update the Getting Started section. Updated the screenshot of the SDK workbench, depends on Use Open edX logo on workbench xblock-sdk#332

@sarina sarina marked this pull request as draft November 18, 2023 04:30
@sarina sarina force-pushed the sarina/improve-tutorial branch from 33dbf92 to fc120e4 Compare November 19, 2023 22:20
@sarina sarina changed the title docs: Improve XBlock tutorial docs: Improve XBlock tutorial sections 1-3 Nov 19, 2023
@sarina sarina requested a review from feanil November 19, 2023 22:23
@sarina sarina marked this pull request as ready for review November 19, 2023 22:23
@sarina
Copy link
Contributor Author

sarina commented Nov 19, 2023

@feanil this PR has a stalled build docs/readthedocs.org:xblock - not sure if that's something that needs to be updated/disabled?


You use the XBlock SDK to create skeleton files for an XBlock. To do this,
follow these steps at a command prompt.

#. Change to the ``xblock_development`` directory, which contains the ``venv`` and ``xblock-sdk`` subdirectories.
#. Change to the ``xblock_development`` directory, which contains the
``var``, ``xblock-env``, and ``xblock-sdk`` subdirectories.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added var because we're told to do that in the clone-sdk file


#. You are prompted to indicate whether or not to create a Django superuser.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this because I was not prompted to create a Django superuser.

image

@sarina sarina force-pushed the sarina/improve-tutorial branch from 812cba3 to 0cda2e1 Compare November 27, 2023 16:05
@feanil
Copy link
Contributor

feanil commented Dec 18, 2023

@sarina I added a commit that should fix up the doc errors, so I think this should be good to go once you rebase and fix the glossary conflict.

@feanil feanil force-pushed the sarina/improve-tutorial branch from d9ed1bf to 64fff3c Compare December 19, 2023 19:00
@feanil feanil merged commit 1a479cc into master Dec 19, 2023
7 checks passed
@feanil feanil deleted the sarina/improve-tutorial branch December 19, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants