Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add catalog url and js namespace for OEP-58 JS translations | FC-0012 #691

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Nov 17, 2023

Description

Support for OEP-58 JavaScript translations:

  • Introduced abstract JavaScript translations support by adding the i18n_js_namespace property and get_i18n_js_namespace method to the SharedBlockBase. This allows XBlocks to define a JavaScript
    namespace so the XBlock i18n runtime service can manage and load JavaScript translations for XBlocks.
  • Added the stub get_javascript_i18n_catalog_url method to the NullI18nService class to be implemented by runtime services.
  • See the edx-platform atlas translations proposal

Related PRs

This pull request blocks the platform PR:

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 17, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 17, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@feanil
Copy link
Contributor

feanil commented Dec 5, 2023

@OmarIthawi let me know when you want me to merge this for you and release it. I noticed the docs build was not triggering correctly and was broken upstream so I've fixed that. You should be able to pick it up if you rebase this PR.

@OmarIthawi
Copy link
Member Author

@feanil thanks for checking this. I think we need one more test case and it should be good.

I'll rebase meanwhile to fix the docs tests.

@OmarIthawi OmarIthawi force-pushed the js_catalog_url branch 2 times, most recently from 85358d2 to 259f2e2 Compare December 9, 2023 19:56
@OmarIthawi OmarIthawi marked this pull request as ready for review December 9, 2023 19:56
@OmarIthawi
Copy link
Member Author

@feanil this is ready for merge.

@feanil feanil merged commit 209ec76 into openedx:master Dec 15, 2023
9 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@feanil
Copy link
Contributor

feanil commented Dec 15, 2023

Also released here: https://github.com/openedx/XBlock/releases/tag/xblock-1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants