-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add catalog url and js namespace for OEP-58 JS translations | FC-0012 #691
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@OmarIthawi let me know when you want me to merge this for you and release it. I noticed the docs build was not triggering correctly and was broken upstream so I've fixed that. You should be able to pick it up if you rebase this PR. |
@feanil thanks for checking this. I think we need one more test case and it should be good. I'll rebase meanwhile to fix the docs tests. |
85358d2
to
259f2e2
Compare
259f2e2
to
de497a8
Compare
@feanil this is ready for merge. |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Also released here: https://github.com/openedx/XBlock/releases/tag/xblock-1.9.0 |
Description
Support for OEP-58 JavaScript translations:
i18n_js_namespace
property andget_i18n_js_namespace
method to theSharedBlockBase
. This allows XBlocks to define a JavaScriptnamespace so the XBlock i18n runtime service can manage and load JavaScript translations for XBlocks.
get_javascript_i18n_catalog_url
method to theNullI18nService
class to be implemented by runtime services.Related PRs
This pull request blocks the platform PR:
atlas pull
for XBlock translations | FC-0012 edx-platform#33698Refs
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.