Skip to content

Commit

Permalink
feat!: drop support for python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
farhan committed May 30, 2024
1 parent 90c9d2c commit e13e066
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.11', '3.12']
python-version: ['3.11', '3.12']
toxenv: [quality, django42]

steps:
Expand All @@ -34,7 +34,7 @@ jobs:
run: tox -e ${{ matrix.toxenv }}

- name: Run Coverage
if: matrix.python-version == '3.8' && matrix.toxenv == 'django42'
if: matrix.python-version == '3.11' && matrix.toxenv == 'django42'
uses: codecov/codecov-action@v4
with:
flags: unittests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pypi-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: setup python
uses: actions/setup-python@v2
with:
python-version: 3.8
python-version: 3.11

- name: Install pip
run: pip install wheel setuptools
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ formats:
build:
os: "ubuntu-22.04"
tools:
python: "3.8"
python: "3.11"

# Optionally set the version of Python and requirements required to build your docs
python:
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ One Time Setup
cd XBlock
# Set up a virtualenv using virtualenvwrapper with the same name as the repo and activate it
mkvirtualenv -p python3.8 XBlock
mkvirtualenv -p python3.11 XBlock
Every time you develop something in this repo
---------------------------------------------
Expand Down
10 changes: 5 additions & 5 deletions docs/xblock-tutorial/getting_started/prereqs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ To build an XBlock, you must have the following tools on your computer.
:depth: 1


**********
Python 3.8
**********
***********
Python 3.11
***********

To run the a virtual environment and the XBlock SDK, and to build an XBlock,
you must have Python 3.8 installed on your computer.
you must have Python 3.1 installed on your computer.

`Download Python`_ for your operating system and follow the installation
instructions.
Expand Down Expand Up @@ -48,7 +48,7 @@ applications you might need.
The instructions and examples in this tutorial use `VirtualEnv`_ and
`VirtualEnvWrapper`_ to build XBlocks. You can also use `PyEnv`_.

After you have installed Python 3.8, follow the `VirtualEnv Installation`_
After you have installed Python 3.11, follow the `VirtualEnv Installation`_
instructions.

For information on creating the virtual environment for your XBlock, see
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def get_version(*file_paths):
'License :: OSI Approved :: Apache Software License',
'Natural Language :: English',
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py{38,311,312}-django{42}, quality, docs
envlist = py{311,312}-django{42}, quality, docs

[pytest]
DJANGO_SETTINGS_MODULE = xblock.test.settings
Expand All @@ -22,7 +22,7 @@ allowlist_externals =

[testenv:docs]
basepython =
python3.8
python3.11
changedir =
{toxinidir}/docs
deps =
Expand Down

0 comments on commit e13e066

Please sign in to comment.