This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
feat: handle nonslug program keys from discovery #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRoytman
approved these changes
Feb 14, 2024
| @@ -127,14 +128,16 @@ def sync_programs(self, program_types): | |||
| if discovery_authoring_org: | |||
| auth_org = existing_org_dictionary.get(discovery_authoring_org.get('uuid')) | |||
| if auth_org: | |||
| # key fromd disco is not guarenteed to be a valid slugfield | |||
There was a problem hiding this comment.
Suggested change
| # key fromd disco is not guarenteed to be a valid slugfield | |
| # key from disco is not guaranteed to be a valid slugfield |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Discovery ADR changed the way Program marketing slugs are generated such that they are no longer guaranteed to be a valid SlugField which makes them unsafe to use as url tokens. Because Registrar supports these values deviating from the source in discovery we're able to translate any non-slug values to something that will work with Registrar and any UI's that rely on it (Program Console + Learner Portal).
This change will only impact new programs moving forward since we do not modify a programs key after a record with that UUID has been synced. This is done to support custom external keys for partners that need a specific value and works to our benefit here.
2U-Internal Ticket: COSMO-185