Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix: add conditional trusted origins update #563

Merged
merged 4 commits into from
Oct 6, 2023
Merged

fix: add conditional trusted origins update #563

merged 4 commits into from
Oct 6, 2023

Conversation

UsamaSadiq
Copy link
Contributor

Description

@UsamaSadiq UsamaSadiq mentioned this pull request Oct 3, 2023
Closed
@awais786
Copy link
Contributor

awais786 commented Oct 6, 2023 •
edited
Loading

https://github.com/edx/edx-internal/pull/9329/files#diff-312f6369d6d9b20e80b359157dc6f65c9cdab0e50aaf2bf7d2c5b17847cac701R56

Settings already merged in internal PR.

@awais786 awais786 mentioned this pull request Oct 6, 2023
Merged
4 tasks
zacharis278
zacharis278 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@zacharis278 zacharis278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh looks like codecov is no longer ignoring the registrar/settings folder which is causing the check to fail on this.

Might be an older issue, just wanted to point it out.

@awais786 awais786 merged commit ce7afd0 into master Oct 6, 2023
3 of 5 checks passed
@awais786 awais786 deleted the csrf_trusted_origins_update branch October 6, 2023 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

@zacharis278 zacharis278 zacharis278 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UsamaSadiq @awais786 @zacharis278 @iamsobanjaved