-
Notifications
You must be signed in to change notification settings - Fork 968
feat: install atlas in mfe
role FC-0012
#6968
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
0b0b81b
to
2183500
Compare
I think we should wait until we implement openedx/openedx-atlas#34 and use npm here |
Install atlas on all Micro-frontends to be used in `make pull_translations` This installs `atlas` on all Ansible build targets such as Native Installation and Devstack. This contribution is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
mfe
rolemfe
role FC-0012
@OmarIthawi do we know the status on this one? Is this still something we're planning on doing or can it be closed? |
@brian-smith-tcril this is waiting for both: 1) Me completing the edx-platform work to have free time for this, 2) 2U input on how should we copy/mimic the Tutor MFE I think we can start with (2) and ping someone from 2U. The review input document we have doesn't list the |
I'm noticing that this is would be the only NPM package which we'd specifically install into the playbook. I imagine we'll need to make sure the same version is also installed into Tutor. All other build requirements are installed transitively via frontend-build, I believe (correct me if I'm wrong). So, instead of installing Atlas here, would it be possible to install it via frontend-build as well? |
in overhangio/tutor-discovery#41 we install |
Right, okay. I was going to say that these requirements should all go into package.json and requirements/yada.in like everything else, but now that I'm thinking about it more, I guess the client of Atlas is not the upstream repo itself, but rather the builder of the repo. In other words, Tutor and Ansible are the users of Atlas, so they will each maintain their own version pins and handle Atlas upgrades separately. You folks probably came to this conclusion a while ago. Sorry for the distraction. This change LGTM. |
@kdmccormick @brian-smith-tcril as far as the place to install the
This was the first attempt to integrate atlas into a builder, and we should remove this pin to avoid confusion now course-discovery has its requirement. I'm keeping this pull request merely as a "todo" item, but I'll close it and re-open once I'm done with the edX Platform work: I've created a pull request to remove the redundant install: |
@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Download the openedx-atlas executable for all Micro-frontends to be used in
make pull_translations
This installs
atlas
on all Ansible build targets such as Native Installation and Devstack.Once merged it will make the
atlas
CLI executable available on all Micro-frontend Dockerfiles and native installation such as Profile, Account, Learning and others. It will make the following command possible:atlas pull
which replacestransifex pull
as part of the Translation Infrastructure update OEP-58 project.Testing
atlas pull
Configuration Pull Request
Make sure that the following steps are done before merging:
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes: